mostly admin updates #137
Closed
mostly admin updates #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitsum
commented
Jul 6, 2024
fitsum
commented
- package updates
- add linter
- remove old lint rc
- add entry
- new file
- lint
- comment out default values for options + lint
- add NOTES with notes about commenting out default values in config
- uncomment default values because they don't seem to interfere with options anymore 🤷
- remove irrelevant notes
jaller94
requested changes
Jul 8, 2024
There was a problem hiding this comment.
Thank you very much for your interest in MapsCII and for contributing to this project. 👍
The addition of the NOTES and TODO files confuse me. Most development ideas are kept in issues on GitHub.
The update of the ESLint config seems very much needed to keep up with new ESLint releases. However, it seems that the rules are not matching the project's current code style and have not been applied to most code files in the src folder.
I wonder what rastapasta thinks.
jaller94
reviewed
Jul 8, 2024
|
The rejection is fair. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.